[ntuple] Fixes / Changes for or related to RField* and RValue#19528
Merged
hahnjo merged 7 commits intoroot-project:masterfrom Aug 5, 2025
Merged
[ntuple] Fixes / Changes for or related to RField* and RValue#19528hahnjo merged 7 commits intoroot-project:masterfrom
RField* and RValue#19528hahnjo merged 7 commits intoroot-project:masterfrom
Conversation
hahnjo
commented
Aug 4, 2025
Test Results 21 files 21 suites 3d 9h 5m 12s ⏱️ Results for commit f917fca. ♻️ This comment has been updated with latest results. |
Even though it is an abstract class, the constructor taking an arbitrary type should not be public.
User code should not inherit from these.
Only REntry should call this for RValues where the RFieldBase is connected to a RPageSink, and orchestrate the calls across all top-level fields.
hahnjo
force-pushed
the
ntuple-field-fixes
branch
from
4415569 to
f917fca
Compare
jblomer
approved these changes
Aug 5, 2025
silverweed
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see individual commits